Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IEC62056 (DLMS/COSEM) protocol dissector #2229

Merged
merged 10 commits into from
Jan 2, 2024
Merged

Add IEC62056 (DLMS/COSEM) protocol dissector #2229

merged 10 commits into from
Jan 2, 2024

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

DLMS is a protocol used to communicate with water, gas and electricity meters.

@0xA50C1A1
Copy link
Contributor Author

Looks like that JA4 related commits broke the build.

@0xA50C1A1 0xA50C1A1 closed this Dec 24, 2023
@0xA50C1A1 0xA50C1A1 reopened this Dec 24, 2023
@0xA50C1A1 0xA50C1A1 marked this pull request as draft December 27, 2023 14:41
IvanNardi
IvanNardi requested changes Jan 2, 2024
View reviewed changes
@0xA50C1A1 0xA50C1A1 marked this pull request as ready for review January 2, 2024 12:42
@0xA50C1A1 0xA50C1A1 requested a review from IvanNardi January 2, 2024 12:42
@0xA50C1A1
Copy link
Contributor Author

@IvanNardi Thanks for the review, I've fixed it.

@IvanNardi
Copy link
Collaborator

@0xA50C1A1, could you confirm that Wireshark is not able to recognize this protocol?

@0xA50C1A1
Copy link
Contributor Author

0xA50C1A1 commented Jan 2, 2024 •
edited
Loading

@0xA50C1A1, could you confirm that Wireshark is not able to recognize this protocol?

Unfortunately, there is still no plugin for this protocol in Wireshark. Well, there was one out-of-tree plugin, but its development has long been abandoned. There's also a Lua script. By the way, I got that pcap samples from these two repositories.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@IvanNardi
Copy link
Collaborator

@0xA50C1A1, could you confirm that Wireshark is not able to recognize this protocol?

Unfortunately, there is still no plugin for this protocol in Wireshark. Well, there was one out-of-tree plugin, but its development has long been abandoned. There's also a Lua script. By the way, I got that pcap samples from these two repositories.

Thanks for this information. I added it to doc/protocols.rst

IvanNardi
IvanNardi approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am learning a lot of interesting uncommon stuff these days... :)
Thanks!

@IvanNardi IvanNardi merged commit 0180c1f into ntop:dev Jan 2, 2024
33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the new-dissector/iec62056 branch January 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanNardi IvanNardi IvanNardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xA50C1A1 @IvanNardi